chore: fix build script#1242
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the build script to only run in workspaces that actually need it. The change adds the --if-present flag to the root build command and removes placeholder build scripts from test workspaces that don't require builds.
- Added
--if-presentflag to the rootnpm run --workspaces buildcommand - Removed empty/placeholder build scripts from
test/wdioandtest/axe-coreworkspaces
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added --if-present flag to workspace build command to skip workspaces without build scripts |
| test/wdio/package.json | Removed placeholder build script that only echoed a message |
| test/axe-core/package.json | Removed placeholder build script that only echoed a message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scottmries
approved these changes
Oct 27, 2025
Contributor
scottmries
left a comment
scottmries
left a comment
There was a problem hiding this comment.
TIL about --if-present. Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only run build scripts if present in the workspaces. For the test workspaces that don't need a build, this removes those that are defined as just empty echos.
Fixes: #1238